Use explicit response code to avoid type error #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request enhances the Flask integration in the Strawberry GraphQL library by improving type safety and removing an unnecessary type ignore comment. The changes focus on the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @DoctorJohn - I've reviewed your changes - here's some feedback:
Overall Comments:
- Good job on improving type safety and removing the
type: ignorecomment. Consider bundling this change with other minor improvements in a future release rather than creating a separate patch release, unless there are other unreleased changes that would justify a new version.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Thanks for adding the Here's a preview of the changelog: This release tweaks the Flask integration's Here's the tweet text: |
DoctorJohn
force-pushed
the
fix-flask-return-type
branch
from
42e5d32
to
8ab4627
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3666 +/- ##
==========================================
+ Coverage 96.67% 97.01% +0.34%
==========================================
Files 503 503
Lines 33457 33458 +1
Branches 5602 5618 +16
==========================================
+ Hits 32343 32460 +117
+ Misses 880 792 -88
+ Partials 234 206 -28 |
patrick91
approved these changes
Oct 11, 2024
DoctorJohn
force-pushed
the
fix-flask-return-type
branch
from
8ab4627
to
f2bc322
Compare
CodSpeed Performance ReportMerging #3666 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes an unneeded
type: ignoreI just stumbled upon and couldn't get out of my head.Types of Changes
Summary by Sourcery
Refactor the Flask integration's
render_graphql_idemethod to use explicit response parameters, improving type safety and removing an unnecessarytype: ignorecomment. Document the change in a newRELEASE.mdfile.Enhancements:
render_graphql_idemethod in the Flask integration to use an explicit response code and content type, removing the need for atype: ignorecomment.Documentation:
RELEASE.mdfile to document the patch release, highlighting the stricter typing in the Flask integration.